LeiRui commented on a change in pull request #262: [IOTDB-144]meta data cache for query URL: https://github.com/apache/incubator-iotdb/pull/262#discussion_r306205394
########## File path: iotdb/src/main/java/org/apache/iotdb/db/query/reader/resourceRelated/UnseqResourceMergeReader.java ########## @@ -84,12 +81,12 @@ public UnseqResourceMergeReader(Path seriesPath, List<TsFileResource> unseqResou continue; } } - tsFileReader = FileReaderManager.getInstance() - .get(tsFileResource.getFile().getPath(), false); metaDataList = tsFileResource.getChunkMetaDatas(); } // create and add ChunkReader with priority + TsFileSequenceReader tsFileReader = FileReaderManager.getInstance() + .get(tsFileResource.getFile().getPath(), tsFileResource.isClosed()); ChunkLoaderImpl chunkLoader = new ChunkLoaderImpl(tsFileReader); for (ChunkMetaData chunkMetaData : metaDataList) { Review comment: If metaDataList size equals 0, then the creation of TsFileSequenceReader can be skipped. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services