Ring-k commented on a change in pull request #366: upgrade from antlr3 to antlr4
URL: https://github.com/apache/incubator-iotdb/pull/366#discussion_r320559584
 
 

 ##########
 File path: 
server/src/main/java/org/apache/iotdb/db/qp/constant/TSParserConstant.java
 ##########
 @@ -36,22 +37,22 @@ private TSParserConstant() {
 
   // used to get operator type when construct operator from AST Tree
   static {
-    antlrQpMap.put(TSParser.KW_AND, SQLConstant.KW_AND);
-    antlrQpMap.put(TSParser.KW_OR, SQLConstant.KW_OR);
-    antlrQpMap.put(TSParser.KW_NOT, SQLConstant.KW_NOT);
+    antlrQpMap.put(TSLexer.KW_AND, SQLConstant.KW_AND);
+    antlrQpMap.put(TSLexer.KW_OR, SQLConstant.KW_OR);
+    antlrQpMap.put(TSLexer.KW_NOT, SQLConstant.KW_NOT);
 
-    antlrQpMap.put(TSParser.EQUAL, SQLConstant.EQUAL);
-    antlrQpMap.put(TSParser.NOTEQUAL, SQLConstant.NOTEQUAL);
-    antlrQpMap.put(TSParser.LESSTHANOREQUALTO, SQLConstant.LESSTHANOREQUALTO);
-    antlrQpMap.put(TSParser.LESSTHAN, SQLConstant.LESSTHAN);
-    antlrQpMap.put(TSParser.GREATERTHANOREQUALTO, 
SQLConstant.GREATERTHANOREQUALTO);
-    antlrQpMap.put(TSParser.GREATERTHAN, SQLConstant.GREATERTHAN);
-    antlrQpMap.put(TSParser.EQUAL_NS, SQLConstant.EQUAL_NS);
+    antlrQpMap.put(TSLexer.EQUAL, SQLConstant.EQUAL);
+    antlrQpMap.put(TSLexer.NOTEQUAL, SQLConstant.NOTEQUAL);
+    antlrQpMap.put(TSLexer.LESSTHANOREQUALTO, SQLConstant.LESSTHANOREQUALTO);
+    antlrQpMap.put(TSLexer.LESSTHAN, SQLConstant.LESSTHAN);
+    antlrQpMap.put(TSLexer.GREATERTHANOREQUALTO, 
SQLConstant.GREATERTHANOREQUALTO);
+    antlrQpMap.put(TSLexer.GREATERTHAN, SQLConstant.GREATERTHAN);
+    antlrQpMap.put(TSLexer.EQUAL_NS, SQLConstant.EQUAL_NS);
 
-    antlrQpMap.put(TSParser.TOK_SELECT, SQLConstant.TOK_SELECT);
-    antlrQpMap.put(TSParser.TOK_FROM, SQLConstant.TOK_FROM);
-    antlrQpMap.put(TSParser.TOK_WHERE, SQLConstant.TOK_WHERE);
-    antlrQpMap.put(TSParser.TOK_QUERY, SQLConstant.TOK_QUERY);
+//    antlrQpMap.put(TSLexer.TOK_SELECT, SQLConstant.TOK_SELECT);
+//    antlrQpMap.put(TSLexer.TOK_FROM, SQLConstant.TOK_FROM);
+//    antlrQpMap.put(TSLexer.TOK_WHERE, SQLConstant.TOK_WHERE);
+//    antlrQpMap.put(TSLexer.TOK_QUERY, SQLConstant.TOK_QUERY);
 
 Review comment:
   It is not necessary. I deleted this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to