jt2594838 commented on a change in pull request #372: [IOTDB-198]Reimplementation sync module URL: https://github.com/apache/incubator-iotdb/pull/372#discussion_r323116633
########## File path: server/src/main/java/org/apache/iotdb/db/sync/sender/manage/SyncFileManager.java ########## @@ -0,0 +1,192 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iotdb.db.sync.sender.manage; + +import java.io.BufferedReader; +import java.io.File; +import java.io.FileReader; +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; +import org.apache.iotdb.db.conf.IoTDBConstant; +import org.apache.iotdb.db.engine.merge.task.MergeTask; +import org.apache.iotdb.db.engine.modification.ModificationFile; +import org.apache.iotdb.db.engine.storagegroup.TsFileResource; +import org.apache.iotdb.db.sync.sender.conf.SyncSenderDescriptor; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class SyncFileManager implements ISyncFileManager { + + private static final Logger LOGGER = LoggerFactory.getLogger(SyncFileManager.class); + + /** + * All storage groups on the disk where the current sync task is executed + */ + private Set<String> allSG; + + /** + * Key is storage group, value is the set of current sealed tsfile in the storage group. + */ + private Map<String, Set<File>> currentSealedLocalFilesMap; + + /** + * Key is storage group, value is the set of last local tsfiles in the storage group, which don't + * contains those tsfiles which are not synced successfully. + */ + private Map<String, Set<File>> lastLocalFilesMap; + + /** + * Key is storage group, value is the valid set of deleted tsfiles which need to be synced to + * receiver end in the storage group. + */ + private Map<String, Set<File>> deletedFilesMap; + + /** + * Key is storage group, value is the valid set of new tsfiles which need to be synced to receiver + * end in the storage group. + */ + private Map<String, Set<File>> toBeSyncedFilesMap; + + private SyncFileManager() { + + } + + public static final SyncFileManager getInstance() { + return SyncFileManagerHolder.INSTANCE; + } + + @Override + public void getCurrentLocalFiles(String dataDir) { + LOGGER.info("Start to get current local files in data folder {}", dataDir); + + currentSealedLocalFilesMap = new HashMap<>(); + // get all files in data dir sequence folder + Map<String, Set<File>> currentAllLocalFiles = new HashMap<>(); + if (!new File(dataDir + File.separatorChar + IoTDBConstant.SEQUENCE_FLODER_NAME).exists()) { + return; + } + File[] allSGFolders = new File( + dataDir + File.separatorChar + IoTDBConstant.SEQUENCE_FLODER_NAME) + .listFiles(); + for (File sgFolder : allSGFolders) { + allSG.add(sgFolder.getName()); + currentAllLocalFiles.putIfAbsent(sgFolder.getName(), new HashSet<>()); + if (sgFolder.listFiles() != null) { + Arrays.stream(sgFolder.listFiles()) + .forEach(file -> currentAllLocalFiles.get(sgFolder.getName()) + .add(new File(sgFolder.getAbsolutePath(), file.getName()))); + } + } + + // get sealed tsfiles + for (Entry<String, Set<File>> entry : currentAllLocalFiles.entrySet()) { + String sgName = entry.getKey(); + currentSealedLocalFilesMap.putIfAbsent(sgName, new HashSet<>()); + for (File file : entry.getValue()) { + if (file.getName().endsWith(ModificationFile.FILE_SUFFIX) || file.getName() + .endsWith(TsFileResource.RESOURCE_SUFFIX) || file.getName() + .endsWith(MergeTask.MERGE_SUFFIX)) { + continue; + } + if (new File(file.getAbsolutePath() + TsFileResource.RESOURCE_SUFFIX).exists() && !new File( + file.getAbsolutePath() + ModificationFile.FILE_SUFFIX).exists() && !new File( + file.getAbsolutePath() + MergeTask.MERGE_SUFFIX).exists()) { + currentSealedLocalFilesMap.get(sgName).add(file); + } + } + } + } + + @Override + public void getLastLocalFiles(File lastLocalFileInfo) throws IOException { + LOGGER.info("Start to get last local files from last local file info {}", + lastLocalFileInfo.getAbsoluteFile()); + lastLocalFilesMap = new HashMap<>(); + if (!lastLocalFileInfo.exists()) { + return; + } + try (BufferedReader reader = new BufferedReader(new FileReader(lastLocalFileInfo))) { + String fileName; + while ((fileName = reader.readLine()) != null) { + String sgName = new File(fileName).getParentFile().getName(); + allSG.add(sgName); + lastLocalFilesMap.putIfAbsent(sgName, new HashSet<>()); + lastLocalFilesMap.get(sgName).add(new File(fileName)); + } + } + } + + @Override + public void getValidFiles(String dataDir) throws IOException { + allSG = new HashSet<>(); + getCurrentLocalFiles(dataDir); + getLastLocalFiles( + new File(SyncSenderDescriptor.getInstance().getConfig().getLastFileInfoPath())); + toBeSyncedFilesMap = new HashMap<>(); + deletedFilesMap = new HashMap<>(); + for (String sgName : allSG) { + toBeSyncedFilesMap.putIfAbsent(sgName, new HashSet<>()); + deletedFilesMap.putIfAbsent(sgName, new HashSet<>()); + for (File newFile : currentSealedLocalFilesMap.getOrDefault(sgName, new HashSet<>())) { Review comment: I suggest `Collections.emptySet()` over `new HashSet<>()` to reduce unnecessary news. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
