[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #339: [IOTDB-158] add metrics service

[GitBox]

samperson1997 commented on a change in pull request #339: [IOTDB-158] add 
metrics service
URL: https://github.com/apache/incubator-iotdb/pull/339#discussion_r325957269
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
 ##########
 @@ -369,6 +374,14 @@ private void confirmMultiDirStrategy() {
     return dataDirs;
   }
 
+  public int getMetricsPort() {
+       return metricsPort;
 
 Review comment:
   Hi, I have noticed that your code style is a little bit different from 
Apache IoTDB (which is Google’s Java Style). If you are using Intellij Idea, 
you could set code style format by "Preferences - Editor - Code Style -Java", 
and set Scheme (by clicking the setting icon beside), "Import Scheme - Intellij 
IDEA code style XML". The code style xml file in our project is called 
`java-google-style.xml`.
   ![屏幕快照 2019-09-19 09 23 
25](https://user-images.githubusercontent.com/19167280/65210221-07788300-dacd-11e9-8275-77b0409d5e93.png)
   ```suggestion
       return metricsPort;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services