Genius-pig commented on a change in pull request #389: [IOTDB-165][TsFile]
Delete a current version and add a number version and an exception.
URL: https://github.com/apache/incubator-iotdb/pull/389#discussion_r326564792
##########
File path:
tsfile/src/test/java/org/apache/iotdb/tsfile/read/filter/IExpressionOptimizerTest.java
##########
@@ -96,9 +95,8 @@ public void testSeriesOnly() {
IExpression expression = BinaryExpression
.and(BinaryExpression.or(singleSeriesExp1, singleSeriesExp2),
singleSeriesExp3);
- Assert.assertEquals(true,
- expression.toString()
- .equals(expressionOptimizer.optimize(expression,
selectedSeries).toString()));
+ Assert.assertEquals(expression.toString(),
+ expressionOptimizer.optimize(expression, selectedSeries).toString());
} catch (QueryFilterOptimizationException e) {
e.printStackTrace();
Review comment:
Use a Assert.fail() is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
