JackieTien97 commented on a change in pull request #429: [IOTDB-205]Support
storage-group-level data ttl
URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r337822532
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/merge/manage/MergeResource.java
##########
@@ -65,24 +65,28 @@
private Map<String, MeasurementSchema> measurementSchemaMap = new
HashMap<>();
private Map<MeasurementSchema, IChunkWriter> chunkWriterCache = new
ConcurrentHashMap<>();
+ private long fileTimeBound = Long.MAX_VALUE;
+
private boolean cacheDeviceMeta = false;
public MergeResource(List<TsFileResource> seqFiles, List<TsFileResource>
unseqFiles) {
- this.seqFiles = seqFiles.stream().filter(res -> res.isClosed() &&
!res.isDeleted())
- .collect(Collectors.toList());
+ this.seqFiles =
+
seqFiles.stream().filter(this::filterResource).collect(Collectors.toList());
this.unseqFiles =
- unseqFiles.stream().filter(res -> res.isClosed() && !res.isDeleted())
- .collect(Collectors.toList());
+
unseqFiles.stream().filter(this::filterResource).collect(Collectors.toList());
+ }
+
+ private boolean filterResource(TsFileResource res) {
+ return res.isClosed() && !res.isDeleted() && res.stillLives(fileTimeBound);
Review comment:
In the before lambda, you didn't judge res.stillLives(fileTimeBound), but in
the `filterResource` you judge it. Will there be some bugs after changing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
