jack870131 commented on a change in pull request #435: [IOTDB-174] Fix querying
timeseries interface cannot make a query by the specified path prefix
URL: https://github.com/apache/incubator-iotdb/pull/435#discussion_r338143925
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -781,20 +777,56 @@ private void findStorageGroup(MNode node, String path,
HashSet<String> res) {
*
* @return a list contains all distinct devices
*/
- Set<String> getAllDevices() {
- return new HashSet<>(getNodesList(3));
+ Set<String> getAllDevices() throws SQLException {
+ List<String> res = new ArrayList<>();
+ MNode node;
+ if ((node = getRoot()) != null) {
+ findDevices(node, "root", res);
+ }
+ return new LinkedHashSet<>(res);
+ }
+
+ private void findDevices(MNode node, String path, List<String> res) {
Review comment:
@qiaojialin It might not have to declare two separate params here, which it
could use node.getName() to get node's name. However, the function above
(findStorageGroup) has also declared like this, so I'm not sure if I have to
change this declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
