Genius-pig commented on a change in pull request #620: [IOTDB-337]Add timestamp precision properties for grafana URL: https://github.com/apache/incubator-iotdb/pull/620#discussion_r353154729
########## File path: grafana/src/main/java/org/apache/iotdb/web/grafana/dao/impl/BasicDaoImpl.java ########## @@ -45,19 +50,43 @@ private static final Logger logger = LoggerFactory.getLogger(BasicDaoImpl.class); + private static final String CONFIG_PROPERTY_FILE = "application.properties"; + private final JdbcTemplate jdbcTemplate; + private static long TIMESTAMP_RADIX = 1L; + @Autowired public BasicDaoImpl(JdbcTemplate jdbcTemplate) { this.jdbcTemplate = jdbcTemplate; + try (InputStream inputStream = new FileInputStream(new File(CONFIG_PROPERTY_FILE))) { Review comment: Why use properties in that way? https://www.baeldung.com/properties-with-spring ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services