fanhualta commented on a change in pull request #657: Serialize filters
URL: https://github.com/apache/incubator-iotdb/pull/657#discussion_r360864723
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/read/filter/basic/UnaryFilter.java
##########
@@ -51,4 +60,36 @@ public FilterType getFilterType() {
@Override
public abstract Filter clone();
+
+ @Override
+ public void serialize(DataOutputStream outputStream) {
+ try {
+ outputStream.write(getSerializeId().ordinal());
+ outputStream.write(filterType.ordinal());
+ ReadWriteIOUtils.writeObject(value, outputStream);
+ } catch (IOException ignored) {
+ // ignored
Review comment:
But I don't think there was no chance to throw an Exception even it sounds
safe technically. In case it has an exception, it'll be hopeless to locate
the bug even if it's a bug from JDK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
