JackieTien97 commented on a change in pull request #652: [386] Vectorize the
raw data query process
URL: https://github.com/apache/incubator-iotdb/pull/652#discussion_r361095183
##########
File path:
server/src/main/java/org/apache/iotdb/db/query/externalsort/ExternalSortJobScheduler.java
##########
@@ -21,15 +21,15 @@
public class ExternalSortJobScheduler {
- private long queryId = 0;
+ private long taskId = 0;
private ExternalSortJobScheduler() {
}
- synchronized long genQueryId() {
- queryId++;
- return queryId;
+ synchronized long genTaskId() {
+ taskId++;
+ return taskId;
Review comment:
If the use of this class is only to generate a global unique taskId for
external sort job, why don't we use a AtomicLong variable, and there is no need
to use synchronized, it is too heavy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
