jixuan1989 commented on a change in pull request #762: [IOTDB-445] Unify the
keyword of "timestamp" and "time"
URL: https://github.com/apache/incubator-iotdb/pull/762#discussion_r373976512
##########
File path:
server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##########
@@ -1167,13 +1167,16 @@ private FilterOperator parsePredicate(PredicateContext
ctx) {
return parseOrExpression(ctx.orExpression());
} else {
Path path = null;
- BasicFunctionOperator basic = null;
+ BasicFunctionOperator basic;
if (ctx.prefixPath() != null) {
path = parsePrefixPath(ctx.prefixPath());
}
if (ctx.suffixPath() != null) {
path = parseSuffixPath(ctx.suffixPath());
}
+ if(ctx.TIME() != null || ctx.TIMESTAMP() != null) {
+ path = new Path(SQLConstant.RESERVED_TIME);
Review comment:
I am not familiar with this part but there is one question, why there is no
code about `path = new Path(SQLConstant.RESERVED_TIME);` in current master
branch? (Or, why you add such a line of code?).
If no such codes, how current master branch support `select ..... where time
> ...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
