qiaojialin commented on a change in pull request #818: [IOTDB-482] Vectorized
TimeGenerator
URL: https://github.com/apache/incubator-iotdb/pull/818#discussion_r380032708
##########
File path:
server/src/main/java/org/apache/iotdb/db/query/timegenerator/EngineTimeGenerator.java
##########
@@ -51,12 +54,17 @@ private void initNode(QueryContext context) throws
StorageEngineException {
@Override
public boolean hasNext() throws IOException {
- return operatorNode.hasNext();
+ return (cacheTimes != null && cacheTimes.hasMoreData()) ||
operatorNode.hasNext();
}
@Override
public long next() throws IOException {
- return operatorNode.next();
+ if (cacheTimes == null || !cacheTimes.hasMoreData()) {
Review comment:
I prefer to implement next() like this:
public BatchData nextBatch() throws IOException {
if (hasCachedBatchData || hasNextBatch()) {
hasCachedBatchData = false;
return batchData;
}
throw new IOException("no next batch");
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
