JackieTien97 commented on a change in pull request #818: [IOTDB-482] Vectorized
TimeGenerator
URL: https://github.com/apache/incubator-iotdb/pull/818#discussion_r380149337
##########
File path:
server/src/main/java/org/apache/iotdb/db/query/timegenerator/EngineNodeConstructor.java
##########
@@ -19,22 +19,22 @@
package org.apache.iotdb.db.query.timegenerator;
+import static org.apache.iotdb.tsfile.read.expression.ExpressionType.SERIES;
+
import org.apache.iotdb.db.engine.querycontext.QueryDataSource;
import org.apache.iotdb.db.exception.StorageEngineException;
import org.apache.iotdb.db.exception.path.PathException;
import org.apache.iotdb.db.metadata.MManager;
import org.apache.iotdb.db.query.context.QueryContext;
import org.apache.iotdb.db.query.control.QueryResourceManager;
-import org.apache.iotdb.db.query.reader.series.SeriesRawDataPointReader;
+import org.apache.iotdb.db.query.reader.series.SeriesRawDataBatchReader;
import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
import org.apache.iotdb.tsfile.read.common.Path;
import org.apache.iotdb.tsfile.read.expression.IExpression;
import org.apache.iotdb.tsfile.read.expression.impl.SingleSeriesExpression;
import org.apache.iotdb.tsfile.read.filter.basic.Filter;
import org.apache.iotdb.tsfile.read.query.timegenerator.node.Node;
-import static org.apache.iotdb.tsfile.read.expression.ExpressionType.SERIES;
-
public class EngineNodeConstructor extends AbstractNodeConstructor {
Review comment:
Actually, I can't get the meaning of AbstractNodeConstructor. Why we need
constructNotSeriesNode() and construct() these two methods. These two methods
call each other iteratively. I think we can combine these two to reduce the
meaningless function call costs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
