JackieTien97 commented on a change in pull request #821: [IOTDB-298]Last 
time-value query
URL: https://github.com/apache/incubator-iotdb/pull/821#discussion_r380537858
 
 

 ##########
 File path: 
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
 ##########
 @@ -680,6 +674,7 @@ public void insert(InsertPlan insertPlan) throws 
QueryProcessException {
       }
       insertPlan.setDataTypes(dataTypes);
       storageEngine.insert(insertPlan);
+      insertPlan.updateMNodeLastValues(node);
 
 Review comment:
   It is not suitable to put the updateMNodeLastValues method in the InsertPlan.
   You can update the last value in the before loop, there you already got the 
measurementNode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to