sunjincheng121 commented on a change in pull request #817: [IOTDB-497] Apache Flink Connector Support URL: https://github.com/apache/incubator-iotdb/pull/817#discussion_r382878858
########## File path: example/flink-example/src/main/java/org/apache/iotdb/flink/LocalDBServer.java ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.iotdb.flink; + +import org.apache.iotdb.db.service.IoTDB; + +public class LocalDBServer { + public static void main(String[] args) { + IoTDB.main(args); Review comment: Can we move this logic into example(Such as bring up a Thread for IoTDB Server), due to `IoTDB.main` is really simple to use. Even I think that starting an IoTDB server can be described in the Readme, just like Kafka's readme.[1] What to you think? [1] https://github.com/apache/incubator-iotdb/tree/master/example/kafka ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
