samperson1997 commented on a change in pull request #1100:
URL: https://github.com/apache/incubator-iotdb/pull/1100#discussion_r416285442



##########
File path: 
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
##########
@@ -274,9 +280,10 @@ public void endFile() throws IOException {
 
   /**
    * Flush ChunkMetadataList and TimeseriesMetaData
+   *
    * @return DeviceMetaDataMap in TsFileMetaData
    */
-  private Map<String, Pair<Long, Integer>> flushAllChunkMetadataList(
+  private List<MetadataIndexNode> flushAllChunkMetadataList(

Review comment:
       Great point, I think we could call it `flushTsFileMetadata`, for 
flushing both ChunkMetadataList and TimeseriesMetaData. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to