jt2594838 commented on pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#issuecomment-626464889
It may work, I think. But to be honest, I dislike the design that you put everything old just in-place with the newest code, and especially such code will only apply to a specified version. Imagine, when IoTDB evolves to 0.12, 0.13, or even higher version, such codes will either go to hell or grow fatter and fatter. What will you do to the classes like OldMetadata, OldDigest? Will we have OldMetadataV1, OldMetadataV2... simultaneously in the server module? I think that is unimaginable. So I would strongly suggest that those implementations be moved to another module, and only leave interfaces of Upgrade in the server module. The upgrade implementation and the old structures are better to be kept away from the up-to-date codes, or they will become a mess and too hard to read. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
