jt2594838 commented on a change in pull request #1169:
URL: https://github.com/apache/incubator-iotdb/pull/1169#discussion_r427947378
##########
File path:
server/src/main/java/org/apache/iotdb/db/auth/role/BasicRoleManager.java
##########
@@ -167,4 +168,21 @@ public void reset() {
rtlist.sort(null);
return rtlist;
}
+
+ @Override
+ public void replaceAllRoles(Map<String, Role> roles) throws AuthException {
+ synchronized (this) {
Review comment:
No, when the function is called, the node will not serve other requests
temporarily. This is only for the concurrent safety of calling the two methods.
And, the lock used in other places is a HashLock and not applicable in this
situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
