jt2594838 commented on a change in pull request #1169:
URL: https://github.com/apache/incubator-iotdb/pull/1169#discussion_r429747057



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -565,6 +605,14 @@ public TSDataType getSeriesType(String path) throws 
MetadataException {
       if (path.equals(SQLConstant.RESERVED_TIME)) {
         return TSDataType.INT64;
       }
+
+      try {
+        MeasurementSchema schema = mRemoteSchemaCache.get(path);

Review comment:
       It is okay, but I think it just repeats the code.
   Generally, the chance that the schema is in the cache is much higher than 
that it is in the MTree because every node only stores a small part of the 
schemas, and checking the cache is much cheaper than searching the tree. I 
wonder where your suggestion comes from.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to