[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1345: [IOTDB-759] Refactor MNode by removing InternalMNode

Tue, 16 Jun 2020 02:34:14 -0700 


samperson1997 commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-iotdb/pull/1345#discussion_r440717097



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/mnode/MNode.java
##########
@@ -127,4 +201,43 @@ public String getName() {
   public void setName(String name) {
     this.name = name;
   }
+
+  public void setChildren(Map<String, MNode> children) {
+    this.children = children;
+  }
+
+  public void serializeTo(BufferedWriter bw) throws IOException {
+    serializeChildren(bw);
+
+    String s = String.valueOf(MetadataConstant.MNODE_TYPE);
+    s += "," + name + ",";

Review comment:
       Actually it's the IDE that recommends me to use `String` instead of 
`StringBuilder`...
   
![image](https://user-images.githubusercontent.com/19167280/84757951-6258ef80-aff7-11ea-9d29-2a4e1be43f83.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to