mychaow commented on a change in pull request #1481:
URL: https://github.com/apache/incubator-iotdb/pull/1481#discussion_r452824398
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -835,29 +823,17 @@ private void insertToTsFileProcessor(InsertRowPlan
insertRowPlan, boolean sequen
}
}
- private void tryToUpdateInsertLastCache(InsertRowPlan plan, Long
latestFlushedTime)
- throws WriteProcessException {
- MNode node = null;
- try {
- MManager manager = IoTDB.metaManager;
- node =
manager.getDeviceNodeWithAutoCreateAndReadLock(plan.getDeviceId());
- String[] measurementList = plan.getMeasurements();
- for (int i = 0; i < measurementList.length; i++) {
- if (plan.getValues()[i] == null) {
- continue;
- }
- // Update cached last value with high priority
- MNode measurementNode = manager.getChild(node, measurementList[i]);
- if (measurementNode != null) {
- ((MeasurementMNode) measurementNode)
- .updateCachedLast(plan.composeTimeValuePair(i), true,
latestFlushedTime);
- }
+ private void tryToUpdateInsertLastCache(InsertRowPlan plan, Long
latestFlushedTime) {
+ MNode node = plan.getDeviceMNode();
+ String[] measurementList = plan.getMeasurements();
+ for (int i = 0; i < measurementList.length; i++) {
+ if (plan.getValues()[i] == null) {
+ continue;
}
- } catch (MetadataException e) {
- // skip last cache update if the local MTree does not contain the schema
- } finally {
+ // Update cached last value with high priority
if (node != null) {
Review comment:
you can move this line out of cycle. `if (node != null) return`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
