neuyilan commented on a change in pull request #1588:
URL: https://github.com/apache/incubator-iotdb/pull/1588#discussion_r463381184
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterDescriptor.java
##########
@@ -244,6 +244,16 @@ private void loadProps() {
.getProperty("enable_auto_create_schema",
String.valueOf(config.isEnableAutoCreateSchema()))));
+ config.setUseAsyncServer(
+ Boolean.parseBoolean(properties.getProperty("is_use_async_server",
+ String.valueOf(config.isUseAsyncServer()))));
+ logger.info("server+{}",config.isUseAsyncServer());
Review comment:
remove the debug log
##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -107,6 +107,12 @@ enable_auto_create_schema=true
# Weak consistency do not synchronize with the leader and simply use the local
data
consistency_level=mid
+#is use async server
+is_use_async_server=true
+
+#is use sync applier
+is_use_async_applier=true
Review comment:
please make the annotation more clearer.
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterDescriptor.java
##########
@@ -244,6 +244,16 @@ private void loadProps() {
.getProperty("enable_auto_create_schema",
String.valueOf(config.isEnableAutoCreateSchema()))));
+ config.setUseAsyncServer(
+ Boolean.parseBoolean(properties.getProperty("is_use_async_server",
+ String.valueOf(config.isUseAsyncServer()))));
+ logger.info("server+{}",config.isUseAsyncServer());
+
+ config.setUseAsyncApplier(
+ Boolean.parseBoolean(properties.getProperty("is_use_async_applier",
+ String.valueOf(config.isUseAsyncApplier()))));
+ logger.info("app+{}",config.isUseAsyncApplier());
Review comment:
the same as above
##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -107,6 +107,12 @@ enable_auto_create_schema=true
# Weak consistency do not synchronize with the leader and simply use the local
data
consistency_level=mid
+#is use async server
+is_use_async_server=true
+
+#is use sync applier
+is_use_async_applier=true
Review comment:
the default value is false. make sure consistent with the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
