jixuan1989 commented on a change in pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r489137977
##########
File path: hadoop/pom.xml
##########
@@ -85,26 +85,6 @@
</archive>
</configuration>
</plugin>
- <plugin>
Review comment:
this plugin is for generating
`hadoop-tsfile-0.11.0-SNAPSHOT-jar-with-dependencies.jar` file, which includes
all dependencies for using hdfs and tsfile.
If the user uses maven, indeed it is useless, but for users who are not use
maven, I think it is useful (or someone who uses maven but there are version
conflicts for hadoop dependencies).
So, I have no idea about whether to remove this plugin? either is ok.
What do you think?
##########
File path: hadoop/pom.xml
##########
@@ -40,7 +40,7 @@
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>tsfile</artifactId>
- <version>0.11.0-SNAPSHOT</version>
Review comment:
+1
##########
File path: site/pom.xml
##########
@@ -39,30 +39,6 @@
</distributionManagement>
<build>
<plugins>
- <!-- copy source codes into vue required folders-->
Review comment:
Hi, why you thought this is duplicated...
have you tried `mvn package -pl site -P site` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
