jixuan1989 commented on a change in pull request #1749:
URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r493446488



##########
File path: 
tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java
##########
@@ -82,6 +83,19 @@ public static boolean readBool(ByteBuffer buffer) {
     return a == 1;
   }
 
+  /**
+   * read a byte from inputStream.
+   */
+  public static byte readByte(InputStream inputStream) throws IOException {

Review comment:
       hm.. this method is overdesigned..
   
   If you read `InputStream.read(byte[])` method, you will find it actually 
just call `byte c = (byte)read()`;
   So, just `return (byte) read()` is ok.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to