samperson1997 commented on a change in pull request #2024: URL: https://github.com/apache/iotdb/pull/2024#discussion_r523867657
########## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/DropIndexPlan.java ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iotdb.db.qp.physical.sys; + +import java.io.DataOutputStream; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.List; +import java.util.Objects; +import org.apache.iotdb.db.exception.metadata.IllegalPathException; +import org.apache.iotdb.db.index.common.IndexType; +import org.apache.iotdb.db.metadata.PartialPath; +import org.apache.iotdb.db.qp.logical.Operator; +import org.apache.iotdb.db.qp.logical.Operator.OperatorType; +import org.apache.iotdb.db.qp.physical.PhysicalPlan; + +public class DropIndexPlan extends PhysicalPlan { + + protected List<PartialPath> paths; + private IndexType indexType; + + public DropIndexPlan() { + super(false, Operator.OperatorType.DROP_INDEX); + } + + public DropIndexPlan(List<PartialPath> paths, IndexType indexType) { + super(false, OperatorType.DROP_INDEX); + this.paths = paths; + this.indexType = indexType; + + } + + public void setPaths(List<PartialPath> paths) { Review comment: ```suggestion @Override public void setPaths(List<PartialPath> paths) { ``` ########## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/CreateIndexPlan.java ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iotdb.db.qp.physical.sys; + +import java.io.DataOutputStream; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.iotdb.db.exception.metadata.IllegalPathException; +import org.apache.iotdb.db.index.common.IndexType; +import org.apache.iotdb.db.metadata.PartialPath; +import org.apache.iotdb.db.qp.logical.Operator.OperatorType; +import org.apache.iotdb.db.qp.physical.PhysicalPlan; +import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils; + +public class CreateIndexPlan extends PhysicalPlan { + + protected List<PartialPath> paths; + private Map<String, String> props; + private long time; + private IndexType indexType; + + public CreateIndexPlan(){ + super(false, OperatorType.CREATE_INDEX); + canBeSplit = false; + } + + public CreateIndexPlan(List<PartialPath> paths, Map<String, String> props, long startTime, + IndexType indexType) { + super(false, OperatorType.CREATE_INDEX); + this.paths = paths; + this.props = props; + time = startTime; + this.indexType = indexType; + canBeSplit = false; + } + + public long getTime() { + return time; + } + + public void setTime(long time) { + this.time = time; + } + + public IndexType getIndexType() { + return indexType; + } + + public void setIndexType(IndexType indexType) { + this.indexType = indexType; + } + + public Map<String, String> getProps() { + return props; + } + + public void setProps(Map<String, String> props) { + this.props = props; + } + + public void setPaths(List<PartialPath> paths) { Review comment: ```suggestion @Override public void setPaths(List<PartialPath> paths) { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
