jt2594838 commented on a change in pull request #2063:
URL: https://github.com/apache/iotdb/pull/2063#discussion_r525158766
##########
File path:
server/src/main/java/org/apache/iotdb/db/query/executor/QueryRouter.java
##########
@@ -225,12 +225,8 @@ public QueryDataSet groupByFill(GroupByTimeFillPlan
groupByFillPlan, QueryContex
@Override
public QueryDataSet lastQuery(LastQueryPlan lastQueryPlan, QueryContext
context)
throws StorageEngineException, QueryProcessException, IOException {
- LastQueryExecutor lastQueryExecutor = getLastQueryExecutor(lastQueryPlan);
+ LastQueryExecutor lastQueryExecutor = new LastQueryExecutor(lastQueryPlan);
return lastQueryExecutor.execute(context, lastQueryPlan);
}
- protected LastQueryExecutor getLastQueryExecutor(LastQueryPlan
lastQueryPlan) {
Review comment:
Yes, indeed. I hope you can make some interfaces out of it, which would
better not be modified so frequently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
