Genius-pig commented on a change in pull request #2087:
URL: https://github.com/apache/iotdb/pull/2087#discussion_r528588358
##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/strategy/SqlBase.g4
##########
@@ -1272,6 +1268,8 @@ UNDERLINE : '_';
NaN : 'NaN';
+SDT : 'SDT';
Review comment:
Why write like this. Does SDT didn't need case insensitive?
##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/strategy/SqlBase.g4
##########
@@ -641,6 +640,7 @@ dateFormat
constant
: dateExpression
| NaN
+ | SDT
Review comment:
if SDT is a constant, I don't think it needs a keyword.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
