EJTTianYu commented on a change in pull request #2080:
URL: https://github.com/apache/iotdb/pull/2080#discussion_r529249093
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1718,10 +1744,30 @@ private void closeUnsealedTsFileProcessorCallBack(
/**
* close compaction merge callback, to release some locks
*/
- private void closeCompactionMergeCallBack() {
- this.compactionMergeWorking = false;
- synchronized (closeStorageGroupCondition) {
- closeStorageGroupCondition.notifyAll();
+ private void closeCompactionMergeCallBack(boolean isMerge, long
timePartitionId) {
+ if (isMerge &&
IoTDBDescriptor.getInstance().getConfig().isEnableContinuousCompaction()) {
+ if (!CompactionMergeTaskPoolManager.getInstance().isTerminated()) {
Review comment:
this if-else could be removed as during the whole process,
`CompactionMergeTaskPoolManager` is never Terminated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
