Alima777 commented on a change in pull request #2164:
URL: https://github.com/apache/iotdb/pull/2164#discussion_r534055844
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -725,19 +719,30 @@ private TSExecuteStatementResp
internalExecuteQueryStatement(String statement,
if (plan instanceof AuthorPlan) {
plan.setLoginUserName(username);
}
+
+ TSExecuteStatementResp resp = null;
+
+ if (plan instanceof QueryPlan) {
+ resp = getQueryColumnHeaders(plan, username);
+ }
// create and cache dataset
QueryDataSet newDataSet = createQueryDataSet(queryId, plan);
+
+ if (plan instanceof ShowPlan || plan instanceof AuthorPlan) {
+ resp = getListDataResp(newDataSet);
+ }
Review comment:
Rename this method as `getListDataSetHeaders` to keep the consistence.
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -725,19 +719,30 @@ private TSExecuteStatementResp
internalExecuteQueryStatement(String statement,
if (plan instanceof AuthorPlan) {
plan.setLoginUserName(username);
}
+
+ TSExecuteStatementResp resp = null;
+
+ if (plan instanceof QueryPlan) {
+ resp = getQueryColumnHeaders(plan, username);
+ }
Review comment:
```suggestion
// execute it before createDataSet since it may change the content of
query plan
if (plan instanceof QueryPlan) {
resp = getQueryColumnHeaders(plan, username);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
