jixuan1989 commented on a change in pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209#discussion_r541521987
##########
File path:
server/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
##########
@@ -82,11 +82,9 @@ public static TVList newList(TSDataType dataType) {
public static long tvListArrayMemSize(TSDataType type) {
long size = 0;
// time size
- size +=
- PrimitiveArrayManager.ARRAY_SIZE * 8;
+ size += (long) PrimitiveArrayManager.ARRAY_SIZE * 8L;
Review comment:
Hi, is this really needed?
I think `PrimitiveArrayManager.ARRAY_SIZE * 8` is far less than
Integer.MAX_VALUE.
(even the overflow may occur, just changing `8` to `8L` is fine, right?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
