qiaojialin commented on a change in pull request #2220:
URL: https://github.com/apache/iotdb/pull/2220#discussion_r541490014
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -330,37 +334,36 @@ public void recover() {
return;
}
if (fullMerge) {
Review comment:
The fullMerge is not used now, it's better to add comment or javadoc to
describe what is fullmerge
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/compaction/utils/CompactionLogger.java
##########
@@ -42,15 +40,17 @@
public CompactionLogger(String storageGroupDir, String storageGroupName)
throws IOException {
logStream = new BufferedWriter(
new FileWriter(SystemFileFactory.INSTANCE.getFile(storageGroupDir,
- storageGroupName + COMPACTION_LOG_NAME), true));
+ storageGroupName + COMPACTION_LOG_NAME), false));
Review comment:
why false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
