jt2594838 commented on a change in pull request #2293:
URL: https://github.com/apache/iotdb/pull/2293#discussion_r547008450
##########
File path: cluster/src/assembly/resources/sbin/start-node.sh
##########
@@ -18,6 +18,14 @@
# under the License.
#
+# Set max number of open files
+Max_Num=$(ulimit -n)
+if [ $Max_Num -ne 65535 ]; then
+ ulimit -n 65535
+ if [ $? -ne 0 ]; then
+ echo "Warning: Failed to set max number of files to be 65535, please
use 'ulimit -n 65535' to set it when you use iotdb in production environments."
+ fi
+fi
Review comment:
1. I think it should be put into `env.sh` as it changes an environment
variable;
2. Instead of `-ne`, better to use less than.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
