HTHou commented on pull request #2435: URL: https://github.com/apache/iotdb/pull/2435#issuecomment-755851748
Hi, I checked the NewTsFile branch carefully. I found the if you change the `short` to `byte` in this PR, you may have to modify a lot of code in TsFile module. There are two ways, one is moving the TsFile part of this PR to another PR commit into `NewTsFile`. Another is just keeping the `short` here, once this PR merged into master, I'll resolve the conflicts in `NewTsFile`. I think either way is OK. Which one would you like? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
