yuqi1129 opened a new pull request #2457:
URL: https://github.com/apache/iotdb/pull/2457
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Thanks for trying to help us make Apache IoTDB be the best it can be!
Please fill out as much of the following information as is possible (where
relevant, and remove it
when irrelevant) to help make the intention and scope of this PR clear in
order to ease review. -->
## Description
This PR try to fix the bug in the method `canSkipDelete` about the skip
logic.
# Detail
if the TsFileResource has start with T1 and T2, that's [T1, T2], when we
try to delete a range [T3, T4]
if T3 <= T2 **or** T4 >= T1, we can make sure the two range has
intersection, and `canSkipDelete` should return false
The reason why this bug has not been trigger is that, the parameter of [T3,
T4] is [Long.Min, Long.Max], and the expression
T3 <= T2 and T4 > T1 is always true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
