kr11 commented on a change in pull request #2444:
URL: https://github.com/apache/iotdb/pull/2444#discussion_r553810336
##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java
##########
@@ -181,53 +181,63 @@ public void setArray(int parameterIndex, Array x) throws
SQLException {
@Override
public void setAsciiStream(int parameterIndex, InputStream x) throws
SQLException {
Review comment:
The method `setArray()` is quite similar to other changed methods, why
not let `setArray()` throw `PARAMETER_SUPPORTED` too?
##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java
##########
@@ -181,53 +181,63 @@ public void setArray(int parameterIndex, Array x) throws
SQLException {
@Override
public void setAsciiStream(int parameterIndex, InputStream x) throws
SQLException {
- throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
+ // throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
Review comment:
Remove commented-out codes
##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java
##########
@@ -181,53 +181,63 @@ public void setArray(int parameterIndex, Array x) throws
SQLException {
@Override
public void setAsciiStream(int parameterIndex, InputStream x) throws
SQLException {
- throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
+ // throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
+ throw new SQLException(Constant.PARAMETER_SUPPORTED);
}
@Override
public void setAsciiStream(int parameterIndex, InputStream x, int length)
throws SQLException {
- throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
+ // throw new SQLException(METHOD_NOT_SUPPORTED_STRING);
Review comment:
Use `2 spaces` instead of `TAB` as indent characters.
Consider importing the code format `$IoTDB_HOME/java-google-style.xml` into
IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
