SteveYurongSu commented on a change in pull request #2469:
URL: https://github.com/apache/iotdb/pull/2469#discussion_r559321644
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkWriterImpl.java
##########
@@ -139,21 +139,21 @@ private void checkSdtEncoding() {
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmin")) {
try {
-
sdtEncoder.setCompMin(Double.parseDouble(measurementSchema.getProps().get("compmin")));
+
sdtEncoder.setCompMinTime(Double.parseDouble(measurementSchema.getProps().get("compmin")));
Review comment:
`compmin` -> `compmintime`
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkWriterImpl.java
##########
@@ -139,21 +139,21 @@ private void checkSdtEncoding() {
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmin")) {
try {
-
sdtEncoder.setCompMin(Double.parseDouble(measurementSchema.getProps().get("compmin")));
+
sdtEncoder.setCompMinTime(Double.parseDouble(measurementSchema.getProps().get("compmin")));
} catch (NumberFormatException e) {
logger.error("meet error when formatting SDT compression minimum");
}
}
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmax")) {
Review comment:
`compmax` -> `compmaxtime`
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkWriterImpl.java
##########
@@ -139,21 +139,21 @@ private void checkSdtEncoding() {
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmin")) {
Review comment:
Don't forget to modify the most important code here. Please have a
manual test.
`compmin` -> `compmintime`
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkWriterImpl.java
##########
@@ -139,21 +139,21 @@ private void checkSdtEncoding() {
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmin")) {
try {
-
sdtEncoder.setCompMin(Double.parseDouble(measurementSchema.getProps().get("compmin")));
+
sdtEncoder.setCompMinTime(Double.parseDouble(measurementSchema.getProps().get("compmin")));
} catch (NumberFormatException e) {
logger.error("meet error when formatting SDT compression minimum");
}
}
if (isSdtEncoding &&
measurementSchema.getProps().containsKey("compmax")) {
try {
-
sdtEncoder.setCompMax(Double.parseDouble(measurementSchema.getProps().get("compmax")));
+
sdtEncoder.setCompMaxTime(Double.parseDouble(measurementSchema.getProps().get("compmax")));
Review comment:
`compmax` -> `compmaxtime`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
