HTHou commented on a change in pull request #2582:
URL: https://github.com/apache/iotdb/pull/2582#discussion_r565866626
##########
File path:
server/src/main/java/org/apache/iotdb/db/sync/sender/manage/SyncFileManager.java
##########
@@ -102,35 +107,45 @@ public void getCurrentLocalFiles(String dataDir) {
.equals(TsFileConstant.TMP_SUFFIX)) {
continue;
}
- allSGs.putIfAbsent(sgFolder.getName(), new HashSet<>());
+ allSGs.putIfAbsent(sgFolder.getName(), new HashMap<>());
currentAllLocalFiles.putIfAbsent(sgFolder.getName(), new HashMap<>());
- for (File timeRangeFolder : sgFolder.listFiles()) {
- try {
- Long timeRangeId = Long.parseLong(timeRangeFolder.getName());
-
currentAllLocalFiles.get(sgFolder.getName()).putIfAbsent(timeRangeId, new
HashSet<>());
- File[] files = timeRangeFolder.listFiles();
- Arrays.stream(files)
- .forEach(file ->
currentAllLocalFiles.get(sgFolder.getName()).get(timeRangeId)
+ for (File virtualSgFolder : sgFolder.listFiles()) {
+ try {
+ Long vgId = Long.parseLong(virtualSgFolder.getName());
+ allSGs.get(sgFolder.getName()).putIfAbsent(vgId, new HashSet<>());
Review comment:
The indent...
##########
File path:
server/src/main/java/org/apache/iotdb/db/sync/sender/transfer/SyncClient.java
##########
@@ -470,17 +475,22 @@ public void sync() throws IOException {
throw new SyncConnectionException("Unable to connect to receiver",
e);
}
logger.info(
- "Sync process starts to transfer data of storage group {}, it has
{} time ranges.",
+ "Sync process starts to transfer data of storage group {}, it has
{} virtual storage group.",
Review comment:
```suggestion
"Sync process starts to transfer data of storage group {}, it
has {} virtual storage groups.",
```
##########
File path:
server/src/main/java/org/apache/iotdb/db/sync/sender/transfer/SyncClient.java
##########
@@ -515,9 +525,9 @@ public void syncDeletedFilesNameInOneGroup(String sgName,
Long timeRangeId,
logger.info("Start to sync names of deleted files in storage group {}",
sgName);
for (File file : deletedFilesName) {
try {
- if (serviceClient.syncDeletedFileName(file.getName()).code ==
SUCCESS_CODE) {
+ if (serviceClient.syncDeletedFileName(getFileNameWithSG(file)).code ==
SUCCESS_CODE) {
logger.info("Receiver has received deleted file name {}
successfully.", file.getName());
Review comment:
```suggestion
logger.info("Receiver has received deleted file name {}
successfully.", getFileNameWithSG(file));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
