qiaojialin commented on a change in pull request #2468:
URL: https://github.com/apache/iotdb/pull/2468#discussion_r577340029
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -973,8 +975,41 @@ private boolean match(PartialPath fullPath, String[]
prefixNodes) {
}
- protected MeasurementMNode getMeasurementMNode(MNode deviceMNode, String
measurement) {
- return (MeasurementMNode) deviceMNode.getChild(measurement);
+ protected MeasurementMNode getMeasurementMNode(MNode deviceMNode, String
measurement, TSDataType dataType)
Review comment:
This is a get function, it is designed to get a MNode, not changing a
MNode...
If can not get a MeasurementMNode, it means an error occurs when creating
timeseries previously. We should throw exception here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
