yuqi1129 commented on a change in pull request #2662:
URL: https://github.com/apache/iotdb/pull/2662#discussion_r583648855
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/client/sync/SyncClientPool.java
##########
@@ -125,25 +137,25 @@ private Client waitForClient(Deque<Client> clientStack,
ClusterNode node, int no
* @param node
* @param client
*/
- void putClient(Node node, Client client) {
+ public void putClient(Node node, Client client) {
ClusterNode clusterNode = new ClusterNode(node);
// As clientCaches is ConcurrentHashMap, computeIfAbsent is thread safety.
- Deque<Client> clientStack = clientCaches.computeIfAbsent(clusterNode, n ->
new ArrayDeque<>());
+ Deque<Client> clientDeque = clientCaches.computeIfAbsent(clusterNode, n ->
new ArrayDeque<>());
synchronized (this) {
if (client.getInputProtocol() != null &&
client.getInputProtocol().getTransport().isOpen()) {
- clientStack.push(client);
+ clientDeque.push(client);
NodeStatusManager.getINSTANCE().activate(node);
} else {
try {
- clientStack.push(syncClientFactory.getSyncClient(node, this));
+ clientDeque.push(syncClientFactory.getSyncClient(node, this));
NodeStatusManager.getINSTANCE().activate(node);
+ this.notify();
} catch (TTransportException e) {
logger.error("Cannot open transport for client {}", node, e);
nodeClientNumMap.computeIfPresent(clusterNode, (n, oldValue) ->
oldValue - 1);
NodeStatusManager.getINSTANCE().deactivate(node);
}
}
- this.notifyAll();
Review comment:
> but I don't know why remove this line here to above
My intention is just to replace notifyAll() with notify(), it's a mistake to
move to the inner try block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
