zhanglingzhe0820 commented on a change in pull request #2739:
URL: https://github.com/apache/iotdb/pull/2739#discussion_r584408981
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/merge/selector/MaxFileMergeFileSelector.java
##########
@@ -228,7 +227,7 @@ private void selectOverlappedSeqFiles(TsFileResource
unseqFile) {
if (seqSelected[i] || !seqFile.getDevices().contains(deviceId)) {
continue;
}
- long seqEndTime = seqFile.getEndTime(deviceId);
+ long seqEndTime = seqFile.isClosed() ? seqFile.getEndTime(deviceId) :
Long.MAX_VALUE;
Review comment:
> hi @zhanglingzhe0820 @jixuan1989 @qiaojialin ,I have a question.
> if a seqfile do not closed. and then is there a conflict? flushing and
merging...
>
> 1. merging finished, need delete old tsfile , if this seqfile do not
closed, can this delete ?
> 2. if flushing data when merging... , maybe have a chunk data do not
write tsfile, but this tsfile merged..
hi
1. unsealed seq file will not be selected to a merge task so it will not be
deleted.
2. a file which is flushing is also an unsealed file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
