LebronAl commented on a change in pull request #2740:
URL: https://github.com/apache/iotdb/pull/2740#discussion_r585402842
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterConfig.java
##########
@@ -28,20 +28,19 @@
static final String CONFIG_NAME = "iotdb-cluster.properties";
- private String clusterRpcIp = "127.0.0.1";
+ private String internalIp = "127.0.0.1";
private int internalMetaPort = 9003;
private int internalDataPort = 40010;
- private int clusterRpcPort = 55560;
+ private int clusterRpcPort = 6667;
- /** each one is a "<IP | domain name>:<meta port>:<data port>:<client
port></>" string tuple */
+ /** each one is a {internalIp | domain name}:{meta port} string tuple */
private List<String> seedNodeUrls =
- Arrays.asList(
- "127.0.0.1:9003:40010:55560", "127.0.0.1:9005:40012:55561",
"127.0.0.1:9007:40014:55562");
+ Arrays.asList(String.format("%s:%d", internalIp, internalMetaPort));
Review comment:
OK, just leave this review away
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/utils/ClusterNode.java
##########
@@ -73,6 +75,9 @@ public String toString() {
+ dataPort
+ ", clientPort="
+ clientPort
+ + ", clientIp='"
+ + clientIp
+ + '\''
Review comment:
I mean `'\'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
