fanhualta commented on a change in pull request #3191:
URL: https://github.com/apache/iotdb/pull/3191#discussion_r639844152
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/log/snapshot/PullSnapshotTask.java
##########
@@ -173,23 +181,35 @@ private boolean pullSnapshot(int nodeIndex) throws
InterruptedException, TExcept
@Override
public Void call() {
- persistTask();
request = new PullSnapshotRequest();
request.setHeader(descriptor.getPreviousHolders().getHeader());
+ request.setRaftId(descriptor.getPreviousHolders().getId());
request.setRequiredSlots(descriptor.getSlots());
request.setRequireReadOnly(descriptor.isRequireReadOnly());
+ logger.info("{}: data migration starts.", newMember.getName());
boolean finished = false;
- int nodeIndex = -1;
+ int nodeIndex = ((PartitionGroup)
newMember.getAllNodes()).indexOf(newMember.getThisNode()) - 1;
while (!finished) {
try {
// sequentially pick up a node that may have this slot
nodeIndex = (nodeIndex + 1) % descriptor.getPreviousHolders().size();
+ long startTime = System.currentTimeMillis();
finished = pullSnapshot(nodeIndex);
if (!finished) {
+ if (logger.isDebugEnabled()) {
+ logger.debug(
+ "Cannot pull slot {} from {}, retry",
+ descriptor.getSlots(),
+ descriptor.getPreviousHolders().get(nodeIndex));
+ }
Thread.sleep(
ClusterDescriptor.getInstance().getConfig().getPullSnapshotRetryIntervalMs());
}
+ logger.debug(
+ "{}: Data migration ends, cost {}ms",
+ newMember,
+ (System.currentTimeMillis() - startTime));
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
