jt2594838 commented on a change in pull request #4079:
URL: https://github.com/apache/iotdb/pull/4079#discussion_r738869147
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/query/fill/ClusterPreviousFill.java
##########
@@ -120,7 +121,9 @@ private TimeValuePair performPreviousFill(
}
CountDownLatch latch = new CountDownLatch(partitionGroups.size());
PreviousFillHandler handler = new PreviousFillHandler(latch);
-
+ // TODO it is not suitable for register and deregister an Object to JMX to
such a frequent
+ // function call.
+ // BUT is it suitable to create a thread pool for each calling??
ExecutorService fillService =
Executors.newFixedThreadPool(partitionGroups.size());
Review comment:
Certainly, I put it up because I thought the focus of this PR is pool
refactoring so this is also part of it. Please create a related issue to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
