ericpai commented on a change in pull request #4517:
URL: https://github.com/apache/iotdb/pull/4517#discussion_r766449939
##########
File path:
server/src/main/java/org/apache/iotdb/db/query/udf/core/layer/RawQueryInputLayer.java
##########
@@ -127,7 +135,7 @@ public boolean next() throws IOException,
QueryProcessException {
for (int i = currentRowIndex + 1; i < rowRecordList.size(); ++i) {
Object[] rowRecordCandidate = rowRecordList.getRowRecord(i);
- if (rowRecordCandidate[columnIndex] != null) {
+ if (isCurRowAllNull || rowRecordCandidate[columnIndex] != null) {
Review comment:
The comment has been updated.
The original has a bug that when consuming cached rows, it should check
every visited row whether all fields are null, not the `isCurRowAllNull`
variable. Currently I call `InputRowUtils.isAllNull()` every time we visit one
row. This behavior is correct but may cause low performance if there're too
many columns. I will change the impelementation of
`ElasticSerializableRowRecordList` later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
