wangchao316 commented on a change in pull request #5287:
URL: https://github.com/apache/iotdb/pull/5287#discussion_r830599564



##########
File path: 
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeDescriptor.java
##########
@@ -42,42 +43,52 @@ public ConfigNodeConf getConf() {
     return conf;
   }
 
-  public String getPropsDir() {

Review comment:
       fixed

##########
File path: 
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfCheck.java
##########
@@ -44,17 +45,13 @@
 
   private Properties specialProperties;
 
-  public void checkConfig() throws RepeatConfigurationException, IOException {
-
-    String propsDir = ConfigNodeDescriptor.getInstance().getPropsDir();
-    if (propsDir == null) {
-      // Skip configuration check when developer mode or test mode
-      return;
-    }
+  private ConfigNodeConfCheck() {
     specialProperties = new Properties();
+  }
 
+  public void checkConfig() throws ConfigurationException, IOException, 
StartupException {
     File specialPropertiesFile =
-        new File(propsDir + File.separator + 
ConfigNodeConstant.SPECIAL_CONF_NAME);
+        new File(conf.getSystemDir() + File.separator + 
ConfigNodeConstant.SPECIAL_CONF_NAME);

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to