OneSizeFitsQuorum commented on a change in pull request #5289:
URL: https://github.com/apache/iotdb/pull/5289#discussion_r830619681
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -25,29 +25,29 @@ typedef i32 int
typedef i64 long
struct CreateSchemaRegionReq {
- 1: required list<int> DataNodeID
+ 1: required list<int> dataNodeID
2: required int schemaRegionID
}
struct CreateDataRegionReq {
- 1: required list<int> DataNodeID
+ 1: required list<int> dataNodeID
2: required int dataRegionID
}
struct CreateDataPartitionReq{
- 1: required list<int> DataNodeID
+ 1: required list<int> dataNodeID
2: required int dataRegionID
3: required long timeInterval
}
struct MigrateSchemaRegionReq{
- 1: required int previousNodeID
Review comment:
I would suggest to use `sourceDataNodeID` and `targetDataNodeID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
