flashzxi commented on a change in pull request #5273:
URL: https://github.com/apache/iotdb/pull/5273#discussion_r830747437



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/SqlLexer.g4
##########
@@ -827,7 +827,8 @@ MOD : '%';
 
 // Operators. Comparation
 
-OPERATOR_EQ : '=' | '==';
+OPERATOR_DEQ : '==';

Review comment:
       if just use OPERATOR_EQ, parser can't tell the difference between 
"compare equal to" and "valuation".
   for example:
   
   select ts=1 and udf(ts,"id"="value") from root.test;
   
   parser don't know whether "id"="value" means valuation or means a string 
equals to another string




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to