ZhanGHanG9991 commented on code in PR #7277:
URL: https://github.com/apache/iotdb/pull/7277#discussion_r967004410
##########
server/src/main/java/org/apache/iotdb/db/mpp/aggregation/MaxTimeDescAccumulator.java:
##########
@@ -19,29 +19,42 @@
package org.apache.iotdb.db.mpp.aggregation;
-import org.apache.iotdb.tsfile.read.common.TimeRange;
+import org.apache.iotdb.db.mpp.execution.operator.window.IWindow;
import org.apache.iotdb.tsfile.read.common.block.column.Column;
public class MaxTimeDescAccumulator extends MaxTimeAccumulator {
// Column should be like: | Time | Value |
// Value is used to judge isNull()
@Override
- public int addInput(Column[] column, TimeRange timeRange) {
- int curPositionCount = column[0].getPositionCount();
- long curMinTime = timeRange.getMin();
- long curMaxTime = timeRange.getMax();
- for (int i = 0; i < curPositionCount; i++) {
- long curTime = column[0].getLong(i);
- if (curTime > curMaxTime || curTime < curMinTime) {
- return i;
+ public int addInput(Column[] column, IWindow curWindow) {
+ int windowControlColumnIndex = curWindow.getControlColumnIndex();
+ int curPositionCount = column[windowControlColumnIndex].getPositionCount();
+
+ if (curWindow.isTimeWindow()) {
Review Comment:
I've optimized it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
