xingtanzjr commented on code in PR #8640:
URL: https://github.com/apache/iotdb/pull/8640#discussion_r1058712306
##########
tsfile/src/main/java/org/apache/iotdb/tsfile/read/TsFileSequenceReader.java:
##########
@@ -134,6 +134,9 @@ public TsFileSequenceReader(String file, boolean
loadMetadataSize) throws IOExce
}
this.file = file;
tsFileInput = FSFactoryProducer.getFileInputFactory().getTsFileInput(file);
Review Comment:
Current change is OK to resolve the issue.
But to make it more safe, it's better to change the method
`getTsFileInput(file)` to avoid making `null` as a possible returned value.
We can let the method `getTsFileInput` throw `IOException` if the file
doesn't exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
