xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061106008
########## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ########## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.engine.settle; + +import org.apache.iotdb.common.rpc.thrift.TSStatus; +import org.apache.iotdb.common.rpc.thrift.TSettleReq; +import org.apache.iotdb.commons.consensus.DataRegionId; +import org.apache.iotdb.db.conf.IoTDBConfig; +import org.apache.iotdb.db.conf.IoTDBDescriptor; +import org.apache.iotdb.db.engine.StorageEngine; +import org.apache.iotdb.db.engine.compaction.CompactionTaskManager; +import org.apache.iotdb.db.engine.compaction.inner.InnerSpaceCompactionTask; +import org.apache.iotdb.db.engine.compaction.task.AbstractCompactionTask; +import org.apache.iotdb.db.engine.modification.ModificationFile; +import org.apache.iotdb.db.engine.storagegroup.DataRegion; +import org.apache.iotdb.db.engine.storagegroup.TsFileManager; +import org.apache.iotdb.db.engine.storagegroup.TsFileNameGenerator; +import org.apache.iotdb.db.engine.storagegroup.TsFileResource; +import org.apache.iotdb.db.engine.storagegroup.TsFileResourceList; +import org.apache.iotdb.db.engine.storagegroup.TsFileResourceStatus; +import org.apache.iotdb.rpc.RpcUtils; +import org.apache.iotdb.rpc.TSStatusCode; +import org.apache.iotdb.tsfile.utils.TsFileUtils; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +public class SettleRequestHandler { + private static final Logger logger = LoggerFactory.getLogger(SettleRequestHandler.class); + + private boolean testMode = false; + + public boolean isTestMode() { + return testMode; + } + + public void setTestMode(boolean testMode) { + this.testMode = testMode; + } + + public static SettleRequestHandler getInstance() { + return SettleRequestHandlerHolder.INSTANCE; + } + + public TSStatus handleSettleRequest(TSettleReq req) { + List<String> paths = req.getPaths(); + + boolean hasSeqFile = false, hasUnSeqFile = false, hasModsFile = false; + Integer dataRegionId = null; + DataRegion dataRegion = null; + Integer level = null; + String storageGroupName = null; + Long timePartitionId = null; + + Set<String> tsFileNames = new HashSet<>(); + + for (String path : paths) { + File tsFile = new File(path); + if (!tsFile.exists()) { + return RpcUtils.getStatus(TSStatusCode.PATH_NOT_EXIST, "file not exist."); + } + File modsFile = new File(path + ModificationFile.FILE_SUFFIX); + hasModsFile |= modsFile.exists(); + + int fileDataRegionId = TsFileUtils.getDataRegionId(tsFile); + if (dataRegion == null) { + dataRegionId = fileDataRegionId; + dataRegion = StorageEngine.getInstance().getDataRegion(new DataRegionId(dataRegionId)); + } else if (dataRegionId != fileDataRegionId) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PATH, "DataRegion of files is not consistent."); + } + + String sgOfFile = TsFileUtils.getStorageGroup(tsFile); + if (storageGroupName == null) { + storageGroupName = sgOfFile; + } else if (!storageGroupName.equals(sgOfFile)) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PATH, "StorageGroup of files is not consistent."); + } + + long timePartitionOfFile = TsFileUtils.getTimePartition(tsFile); + if (timePartitionId == null) { + timePartitionId = timePartitionOfFile; + } else if (timePartitionId != timePartitionOfFile) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PATH, "TimePartition of files is not consistent."); + } + + String fileName = tsFile.getName(); + TsFileNameGenerator.TsFileName tsFileName; + try { + tsFileName = TsFileNameGenerator.getTsFileName(fileName); + } catch (IOException e) { + return RpcUtils.getStatus(TSStatusCode.ILLEGAL_PATH, "Meet error when parsing TsFileName."); + } + + int levelOfFile = tsFileName.getInnerCompactionCnt(); + if (level == null) { + level = levelOfFile; + } else if (level != levelOfFile) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PARAMETER, "Level of files is not consistent."); + } + + if (TsFileUtils.isSequence(tsFile)) { + hasSeqFile = true; + } else { + hasUnSeqFile = true; + } + tsFileNames.add(fileName); + if (hasSeqFile && hasUnSeqFile) { + return RpcUtils.getStatus( + TSStatusCode.UNSUPPORTED_OPERATION, "Settle by cross compaction is not allowed."); + } + } + + if (!hasModsFile) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PARAMETER, "At least one mods file should be selected"); + } + if (dataRegion == null) { + return RpcUtils.getStatus(TSStatusCode.ILLEGAL_PATH, "DataRegion not exist"); + } + TsFileManager tsFileManager = dataRegion.getTsFileManager(); + if (!tsFileManager.isAllowCompaction()) { + return RpcUtils.getStatus( + TSStatusCode.UNSUPPORTED_OPERATION, "Compaction in this DataRegion is not allowed."); + } + + // try to get a continuous TsFileResource list with input TsFile names + List<TsFileResource> tsFileResources = + getContinuousTsFileResourcesByFileNames( + tsFileManager, timePartitionId, hasSeqFile, tsFileNames); + if (tsFileResources.size() != tsFileNames.size()) { + return RpcUtils.getStatus( + TSStatusCode.ILLEGAL_PARAMETER, "Could not find enough satisfied TsFile"); + } + + IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig(); + if (hasSeqFile && !config.isEnableSeqSpaceCompaction()) { + return RpcUtils.getStatus( + TSStatusCode.UNSUPPORTED_OPERATION, "Compaction in Seq Space is not enabled"); + } + if (hasUnSeqFile && !config.isEnableUnseqSpaceCompaction()) { + return RpcUtils.getStatus( + TSStatusCode.UNSUPPORTED_OPERATION, "Compaction in Unseq Space is not enabled"); + } + if (tsFileResources.size() > config.getMaxInnerCompactionCandidateFileNum()) { Review Comment: We can move this validation before the continuous file validation because this check is more simple to do, which will reduce the resource usage in some scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
